Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transforms.smooth() #301

Closed
1 task
dkrako opened this issue Mar 24, 2023 · 2 comments · Fixed by #555
Closed
1 task

Add transforms.smooth() #301

dkrako opened this issue Mar 24, 2023 · 2 comments · Fixed by #555
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dkrako
Copy link
Contributor

dkrako commented Mar 24, 2023

Description of the problem

Having a way to smooth data would be nice to have.

Description of a solution

The first iteration should at least use the savgol_filter from scipy:
https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.savgol_filter.html#scipy.signal.savgol_filter

Minimum acceptance criteria

  • smooth() method using savgol_filter

Sample Code

This could be the signature:

def smooth(
        arr: list[float] | list[list[float]] | np.ndarray,
        window_length: int = 7,
        polyorder:int = 2,
        delta: float = 1.0,
) -> np.ndarray:
@dkrako dkrako added the enhancement New feature or request label Mar 24, 2023
@dkrako dkrako modified the milestone: Sprint 9 Mar 24, 2023
@dkrako dkrako added this to the Sprint 10 milestone Apr 14, 2023
@dkrako dkrako self-assigned this Apr 14, 2023
@dkrako dkrako removed this from the Sprint 10 milestone Jun 9, 2023
@dkrako dkrako added this to the Sprint 12 milestone Aug 25, 2023
@dkrako dkrako removed their assignment Aug 25, 2023
@dkrako dkrako modified the milestones: Sprint 12, Sprint 16 Aug 25, 2023
@jakobchwastek jakobchwastek self-assigned this Sep 1, 2023
@jakobchwastek
Copy link
Member

Here are some more suggestions for methods to start with

  • Moving Average
  • Exponential Moving Average
  • Gaussian Smoothing

@dkrako
Copy link
Contributor Author

dkrako commented Sep 1, 2023

excellent! you can implement any additional method you like.

@dkrako dkrako modified the milestones: Sprint 16, Sprint 17 Sep 8, 2023
@jakobchwastek jakobchwastek linked a pull request Sep 14, 2023 that will close this issue
10 tasks
@dkrako dkrako modified the milestones: Sprint 17, Sprint 18 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants