-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mypy runs in both pre-commit ci and github actions #573
Comments
my certain vote is to remove both flake8, mypy and pylint completely from pre-commit-ci |
actually I would even opt for removing mypy and pylint from pre-commit completely. they are much too slow, commit times of above 5seconds are totally unacceptable for me and thus pre-commit is currently not very usable as an installed git hook (otherwise one have to type --no-verify everytime on commit). flake8 can stay as it's fast enough. but maybe there's a way to run these only on pull requests and not for commits. |
you can uninstall pre-commit locally, there is no need to have it installed locally |
I have changed my mind, see #587 |
we check mypy with both github actions and pre-commit-ci. maybe we can discuss dropping one (my vote is for github actions).
The text was updated successfully, but these errors were encountered: