Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy runs in both pre-commit ci and github actions #573

Closed
SiQube opened this issue Sep 22, 2023 · 4 comments · Fixed by #587
Closed

mypy runs in both pre-commit ci and github actions #573

SiQube opened this issue Sep 22, 2023 · 4 comments · Fixed by #587

Comments

@SiQube
Copy link
Member

SiQube commented Sep 22, 2023

we check mypy with both github actions and pre-commit-ci. maybe we can discuss dropping one (my vote is for github actions).

@SiQube SiQube changed the title why dual mypy mypy runs in both pre-commit ci and github actions Sep 22, 2023
@dkrako
Copy link
Contributor

dkrako commented Sep 29, 2023

my certain vote is to remove both flake8, mypy and pylint completely from pre-commit-ci

@dkrako
Copy link
Contributor

dkrako commented Sep 29, 2023

actually I would even opt for removing mypy and pylint from pre-commit completely. they are much too slow, commit times of above 5seconds are totally unacceptable for me and thus pre-commit is currently not very usable as an installed git hook (otherwise one have to type --no-verify everytime on commit). flake8 can stay as it's fast enough.

but maybe there's a way to run these only on pull requests and not for commits.

@SiQube
Copy link
Member Author

SiQube commented Sep 29, 2023

you can uninstall pre-commit locally, there is no need to have it installed locally

@dkrako
Copy link
Contributor

dkrako commented Oct 4, 2023

I have changed my mind, see #587

@dkrako dkrako linked a pull request Oct 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants