We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pix2deg() currently assumes that the eye is projected orthogonal to the center of the screen.
It's not always the case that the eye is perfectly centered and so an offset vector should to be specified.
The offset would be best implemented in the center_origin() function in pymovements.gaze.transforms.
center_origin()
pymovements.gaze.transforms
The offset should be given in centimeters and is expected to be a tuple of floats with a zero default (center_offset: tuple[float, float] = (0, 0)).
center_offset: tuple[float, float] = (0, 0)
The calculation should be pretty straight forward.
center_offset
tests/unit/gaze/transforms/center_origin_test.py
pix2deg()
tests/unit/gaze/transforms/pix2deg_test.py
tests/unit/gaze/gaze_transform_test.py
The text was updated successfully, but these errors were encountered:
OmerShubi
Successfully merging a pull request may close this issue.
Description of the problem
pix2deg() currently assumes that the eye is projected orthogonal to the center of the screen.
It's not always the case that the eye is perfectly centered and so an offset vector should to be specified.
Description of the solution
The offset would be best implemented in the
center_origin()
function inpymovements.gaze.transforms
.The offset should be given in centimeters and is expected to be a tuple of floats with a zero default (
center_offset: tuple[float, float] = (0, 0)
).The calculation should be pretty straight forward.
Minimum viable acceptance criteria
center_offset
argument tocenter_origin()
tests/unit/gaze/transforms/center_origin_test.py
center_offset
argument inpix2deg()
tests/unit/gaze/transforms/pix2deg_test.py
tests/unit/gaze/gaze_transform_test.py
The text was updated successfully, but these errors were encountered: