Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add center offset argument to pix2deg() #534

Open
5 tasks
dkrako opened this issue Sep 12, 2023 · 0 comments · May be fixed by #906
Open
5 tasks

Add center offset argument to pix2deg() #534

dkrako opened this issue Sep 12, 2023 · 0 comments · May be fixed by #906
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dkrako
Copy link
Contributor

dkrako commented Sep 12, 2023

Description of the problem

pix2deg() currently assumes that the eye is projected orthogonal to the center of the screen.

It's not always the case that the eye is perfectly centered and so an offset vector should to be specified.

Description of the solution

The offset would be best implemented in the center_origin() function in pymovements.gaze.transforms.

The offset should be given in centimeters and is expected to be a tuple of floats with a zero default (center_offset: tuple[float, float] = (0, 0)).

The calculation should be pretty straight forward.

Minimum viable acceptance criteria

  • add center_offset argument to center_origin()
  • test offset in tests/unit/gaze/transforms/center_origin_test.py
  • reuse center_offset argument in pix2deg()
  • test offset in tests/unit/gaze/transforms/pix2deg_test.py
  • test offset in tests/unit/gaze/gaze_transform_test.py
@dkrako dkrako added the enhancement New feature or request label Sep 12, 2023
@dkrako dkrako added the good first issue Good for newcomers label Feb 22, 2024
@OmerShubi OmerShubi self-assigned this Apr 1, 2024
@OmerShubi OmerShubi linked a pull request Dec 11, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants