Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple occurrences for custom metadata patterns #907

Open
saeub opened this issue Dec 11, 2024 · 1 comment
Open

Support multiple occurrences for custom metadata patterns #907

saeub opened this issue Dec 11, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers nonessential nice to have

Comments

@saeub
Copy link
Collaborator

saeub commented Dec 11, 2024

Description of the problem

#767 introduced user-specified patterns for extracting metadata that does not belong in the gaze dataframe (like stimulus randomization). For patterns that appear multiple times, the implementation currently only stores the first occurrence in the metadata dictionary. It would be nice if all occurrences could be stored (with timestamps).

See this test (the METADATA_1 pattern occurs twice, but only the first occurrence is stored):

r'METADATA_1 (?P<metadata_1>\d+)',

Description of a solution

TODO

Minimum acceptance criteria

Reoccurring messages can be extracted using the metadata_patterns argument.

Sample Code

TODO

@saeub saeub added enhancement New feature or request nonessential nice to have labels Dec 11, 2024
@dkrako
Copy link
Contributor

dkrako commented Dec 11, 2024

ah great, this is related to #887 but here it's related to user-defined patterns instead of the default ones, right? could be a nice follow-up

@dkrako dkrako added the good first issue Good for newcomers label Dec 11, 2024
@saeub saeub changed the title Support multiple occurrences custom metadata patterns Support multiple occurrences for custom metadata patterns Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers nonessential nice to have
Projects
None yet
Development

No branches or pull requests

2 participants