Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ignore override from pyproject.toml #912

Open
SiQube opened this issue Dec 29, 2024 · 2 comments
Open

remove ignore override from pyproject.toml #912

SiQube opened this issue Dec 29, 2024 · 2 comments

Comments

@SiQube
Copy link
Member

SiQube commented Dec 29, 2024

          to not block new pull requests, we ignore `override` for now via #911

Originally posted by @SiQube in #905 (comment)

@SiQube
Copy link
Member Author

SiQube commented Dec 30, 2024

the issue is pretty straight-forward. the base class DatasetDefiintion has for example type: experiment: Experiment | None = None. our implementation of the public datasets, e.g. BSC, then uses experiment: Experiment = Experiment(...) which leads to the override error.

this can be resolved via:

  • use yaml files for dataset definition files #908 (favorite)
  • specifying empty Experiment() etc. in DatasetDefinition
  • assigning baseclass types to datasets, e.g. experiment: Experiment | None = Experiment(...)(to make mypy happy but least favorite)

@SiQube
Copy link
Member Author

SiQube commented Jan 1, 2025

I've started working on resolving #908 via #914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant