Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for new shortcuts #298

Open
12 of 16 tasks
feiss opened this issue Aug 18, 2016 · 21 comments
Open
12 of 16 tasks

Suggestions for new shortcuts #298

feiss opened this issue Aug 18, 2016 · 21 comments

Comments

@feiss
Copy link
Member

feiss commented Aug 18, 2016

Following #154 , support for more shortcuts would be very interesting for desktop users.

(Some of these actions are not yet included in the editor, I'll try to write a spec for each one in a separated issue)

  • w,e,r
    Switch to Translate/Rotate/Scale modes (Maya and Max standard, very convenient)
  • z
    View selected object (f would be a more convenient shortcut for this, but is currently used for 'fullscreen') (see View selection, View All, Reset View #300)
  • a
    View all objects (see View selection, View All, Reset View #300 )
  • ctrl + LMB
    Add object to selection (this could be an whole issue itself, support for multiple selection)
  • ctrl + a
    Select All
  • d
    Duplicate/clone current selection
  • g
    Toggle grid visibility
  • n
    Add new entity
  • supr/backspace
    Delete current selection
  • ctrl+c, ctrl+v
    copy/paste current selection
  • 1,2,3,4
    Switch to Front/Left/Top/Perspective view
  • o
    Toggle local/global transform mode
  • Num +, Num -
    Increase/decrease transform helper (in discrete steps, between (min, max) values)
  • ctrl+alt+i
    Switch Edit and VR modes.
  • Esc for exiting edit mode (current behaviour)
  • h
    Toggle help/shortcuts panel

Shortcut customization in the cheatsheet panel that #276 suggested would be nice, although I don't think it's high priority.

@fernandojsg
Copy link
Member

Thanks! Regarding the esc I was thinking the same but @dmarcos pointed that maybe the VR-scene is capturing esc by itself as it's a very generic shortcut so we can't just hijack it :(

@ngokevin
Copy link
Member

When the inspector is active, the scene should be paused and event listeners should be removed, so keypresses should not do anything.

@fernandojsg
Copy link
Member

@ngokevin yes that's why esc will works while the editor is opened, but if we exit the inspector and go back to the scene we should remove that listener

@feiss
Copy link
Member Author

feiss commented Aug 18, 2016

Can't you just add the event listener after the vr-scene and its events are initialized? (maybe with a setTimeout()?)

@fernandojsg
Copy link
Member

@feiss is not a problem about timing is more a problem on what happens if the vrscene has a listener for esc that does something, if we add a listener we'll screw it, that's why we tend to use rare shortcuts in that situation like ctrl+alt+i.

@fernandojsg
Copy link
Member

h to show shortcut cheatsheet

@feiss
Copy link
Member Author

feiss commented Aug 18, 2016

what about the traditional F1? with additional help links and info

@fernandojsg
Copy link
Member

F1 is reserved usually by the browser, and for example in mac keyboard you need to click Fn + F1 as F1 by default is assigned to lower screen brightness.
Just as completely personal opinion I like having all the shortcuts close to each others so I could have my hand relaxed on the keyboard and just move the fingers to press each shortcut without need to add any movement to my wrist

@feiss
Copy link
Member Author

feiss commented Aug 18, 2016

I'm sold! h then

@fernandojsg
Copy link
Member

Maybe backspace for delete? As mac keyboard doesn't have supr by default, you need to press cmd + backspace

@fernandojsg
Copy link
Member

@feiss Num +, Num - Do you mean for example translate or rotate step by step? In that case in which axis?

@feiss
Copy link
Member Author

feiss commented Aug 18, 2016

backspace/supr: why not both?
num +, num- : no, just visually scaling up/down the helper, without affecting the selection.

@fernandojsg
Copy link
Member

fernandojsg commented Aug 18, 2016

backspace/supr: why not both?

Yep!

num +, num- : no, just visually scaling up/down the helper, without affecting the selection.

I don't get that, right now the helper has a constant size, it's not affected by the zoom of the perspective view do you want to make it bigger/smaller? is that useful?

@fernandojsg
Copy link
Member

By the way can you update the first comment adding task lists so we could keep checking the ones we're finishing? (https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments)

@fernandojsg
Copy link
Member

ctrl+d in windows is add bookmark right? What about using just d without a modifier?

@Coder206
Copy link
Collaborator

@fernandojsg Yes, ctrl+d in Windows adds a bookmark.

@feiss
Copy link
Member Author

feiss commented Aug 18, 2016

allrighty, d without modifier :)

About num+,num-, yup, just change up/down that constant size. You can usually change it in other 3d packages, it's an usability thing. Just think that the transform helper is the most important and used tool of the editor. Anyway, it's not very important, just a small thing.

@fernandojsg
Copy link
Member

Updated the list of shortcuts created based on: #305

@vershwal
Copy link
Contributor

@feiss Could you check the copy/paste selection shortcut?
#426

@feiss
Copy link
Member Author

feiss commented Feb 11, 2017

@vershwal this is current layout in master. Everything works nice. Fernando even added a cut functionality. Will be available very very soon, thanks! 👍

image

@vershwal
Copy link
Contributor

Yes I saw the cut functionality. It works great.

Also by check I meant ticking the copy/paste dialogue in the issue above (Marking it as resolved). Wrong choice of words I guess.

I think you have checked it.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants