Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catchability prior sd multiplied by sqrt(1/nyrs) in FM.tpl #27

Open
grantdadams opened this issue Dec 14, 2024 · 0 comments
Open

Catchability prior sd multiplied by sqrt(1/nyrs) in FM.tpl #27

grantdadams opened this issue Dec 14, 2024 · 0 comments

Comments

@grantdadams
Copy link

If running FM with time-invariant catchability and a prior, FM will decrease q_sigma by a factor of sqrt(1/nyrs).

q_srv is a vector of length nyrs (styr to endyr) even when derived from a single parameter

// matrix q_srv(1,nsrv,styr,endyr)

however, the catchability prior is applied to the entire q_srv vector rather than a single parameter https://github.com/afsc-assessments/flatfish/blob/3d9b975bec0df9b63d8369226e5f3987f15e5b34/src/fm.tpl#L1460C1-L1463C7

effectively multiplying q_sigma by sqrt(1/nyrs)

This may be intended, but wanted to flag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant