-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cohere model integrations #338
Update cohere model integrations #338
Conversation
Hey @Anirudh31415926535, while looking into adding structured output support I saw that the V2 API seemed easier to work with, more aligned with other APIs. I've started work on it in #369. Do you think V2 is better to move forward with? |
Hey @marklysze Yes absolutely! Migrating to the cohere integration to V2 was something that we were thinking about as well haha! Would def appreciate the help here! I can help to review the PR if you're willing to contribute! |
:), my bad, wrong PR! it's #370, sorry! Yes, if we can work on that one that would be better, V2 is so much easier to work with! Please have a look at the PR and if you're happy to continue there feel free to close this one. |
@Anirudh31415926535 are we still proceeding with this? Could you help fix the conflicts and merge the latest code from main? Thanks! |
Hey, not proceeding with this in favour of #370. Will close the PR. |
Why are these changes needed?
This PR aims to fix the cohere integration to the ag2 repo. This PR essentially contains the changes here and here
Checks