Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor emergent parameters code #81

Open
wants to merge 98 commits into
base: main
Choose a base branch
from
Open

Refactor emergent parameters code #81

wants to merge 98 commits into from

Conversation

radka-j
Copy link
Contributor

@radka-j radka-j commented Nov 15, 2024

Refactor of #73

PR overview of main changes:

  • adds Parameters module with compute_darwin_parameters function, which generates n volumes for each plankton group and computes "emergent" parameters from those
    • makes use of NamedArrays
    • the emergent functions are just placeholders, this is also why they are kept in examples for now (to be moved to main library once implemented)
  • adds a test that checks that emergent_parameters have the same values as those that were hand-coded in the N2P2ZD example

Small edits:

  • rename the Dynamic module to Biogeochemistry, this means that models are now accessible as Agate.Models.Biogeochemistry.<struct UUID>
  • update the NPZD example to avoid duplication of parameters (lᵖⁿ and lᶻⁿ were specified twice)

@radka-j radka-j changed the base branch from N_plankton to main December 2, 2024 10:50
@radka-j
Copy link
Contributor Author

radka-j commented Dec 10, 2024

@nanophyto this is now ready for review again. I will continue working on the constructors in a separate PR branched off this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants