Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always drop "Haskell." prefix from module names #379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jespercockx
Copy link
Member

This supersedes #297. The idea (due to @omelkonian) is that any module starting with Haskell. should be treated as defining part of the FFI with Haskell and should thus not be checked for having COMPILE pragmas, but instead be assumed to exist on the Haskell side while dropping the Haskell. prefix from the module name.

@jespercockx
Copy link
Member Author

jespercockx commented Nov 22, 2024

Three things to consider before merging this:

  • There is a risk of introducing a name collision between Haskell.Foo.Bar and Foo.Bar. Can we do anything about this?
  • Should we enforce that Haskell. modules do not produce any output?
  • Can we make it clearer to the user that defining a Haskell. module is an unsafe thing to do? We can certainly add a note to the documentation, but is there anything else we can do?

@jespercockx
Copy link
Member Author

Related: #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant