Skip to content

Commit

Permalink
machines: simplify MACHINEOVERRIDES definitions
Browse files Browse the repository at this point in the history
Prepending new definitions should be preferred to assignment, as it is
simpler and more conducive to defining new machine configurations that
reuse these configurations.

Signed-off-by: Zachary T Welch <[email protected]>
  • Loading branch information
zach-welch-aquabyte authored and agherzan committed Nov 21, 2023
1 parent cfd3eb4 commit 9c81413
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion conf/machine/raspberrypi-cm.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#@NAME: RaspberryPi Compute Module (CM1)
#@DESCRIPTION: Machine configuration for the RaspberryPi Compute Module (CM1)

MACHINEOVERRIDES = "raspberrypi:${MACHINE}"
MACHINEOVERRIDES =. "raspberrypi:"
include conf/machine/raspberrypi.conf

ARMSTUB ?= "armstub.bin"
4 changes: 2 additions & 2 deletions conf/machine/raspberrypi0-2w-64.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
#@NAME: RaspberryPi0 2 Wifi Development Board
#@DESCRIPTION: Machine configuration for the RaspberryPi0 2 Wifi in 64 bits mode

include conf/machine/raspberrypi3-64.conf
MACHINEOVERRIDES =. "raspberrypi3-64:"

MACHINEOVERRIDES := "${@'${MACHINEOVERRIDES}'.replace(':${MACHINE}',':raspberrypi3-64:${MACHINE}')}"
include conf/machine/raspberrypi3-64.conf

MACHINE_EXTRA_RRECOMMENDS += "\
linux-firmware-rpidistro-bcm43436 \
Expand Down
4 changes: 2 additions & 2 deletions conf/machine/raspberrypi0-2w.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
#@NAME: RaspberryPi0 2 Wifi Development Board
#@DESCRIPTION: Machine configuration for the RaspberryPi0 2 Wifi in 32 bits mode

include conf/machine/raspberrypi3.conf
MACHINEOVERRIDES =. "raspberrypi3:"

MACHINEOVERRIDES := "${@'${MACHINEOVERRIDES}'.replace(':${MACHINE}',':raspberrypi3:${MACHINE}')}"
include conf/machine/raspberrypi3.conf

MACHINE_EXTRA_RRECOMMENDS += "\
linux-firmware-rpidistro-bcm43436 \
Expand Down
2 changes: 1 addition & 1 deletion conf/machine/raspberrypi0.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#@NAME: RaspberryPi Zero Development Board
#@DESCRIPTION: Machine configuration for the RaspberryPi Zero board (https://www.raspberrypi.org/blog/raspberry-pi-zero)

MACHINEOVERRIDES = "raspberrypi:${MACHINE}"
MACHINEOVERRIDES =. "raspberrypi:"
include conf/machine/raspberrypi.conf

SERIAL_CONSOLES ?= "115200;ttyAMA0"
2 changes: 1 addition & 1 deletion conf/machine/raspberrypi3-64.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#@NAME: RaspberryPi 3 Development Board
#@DESCRIPTION: Machine configuration for the RaspberryPi 3 in 64 bits mode

MACHINEOVERRIDES = "raspberrypi3:${MACHINE}"
MACHINEOVERRIDES =. "raspberrypi3:"

MACHINE_EXTRA_RRECOMMENDS += "\
linux-firmware-rpidistro-bcm43430 \
Expand Down
2 changes: 1 addition & 1 deletion conf/machine/raspberrypi4-64.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#@NAME: RaspberryPi 4 Development Board (64bit)
#@DESCRIPTION: Machine configuration for the RaspberryPi 4 in 64 bits mode

MACHINEOVERRIDES = "raspberrypi4:${MACHINE}"
MACHINEOVERRIDES =. "raspberrypi4:"

MACHINE_FEATURES += "pci"
MACHINE_EXTRA_RRECOMMENDS += "\
Expand Down

0 comments on commit 9c81413

Please sign in to comment.