Add support for Raspberry Pi Camera Module v3 #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jessseee
commented
Mar 10, 2023
|
@agherzan any updates on this? |
agherzan
requested changes
Apr 3, 2023
agherzan
reviewed
Apr 5, 2023
|
Up for merge if you could also squash docs: Fixed text wrap consistency and added full stop. into the previous commit. There is no need for incremental changes here. |
|
The doc commits have been squashed, should I make any other changes to this PR? |
|
@Jessseee You have a mismatch between the commit author and the SoB line. Check the CI pipeline for DCO. |
Signed-off-by: Jesse Visser <[email protected]>
Signed-off-by: Jesse Visser <[email protected]>
|
@agherzan My bad, the authorship of the commits should be corrected. |
|
These break old kernels like latest 5.10 on the layer. |
|
The overlays/imx708.dtbo is not supported and backport the dtbo is not accepted so one possible solutions is doping the kernel 5.10 version on the master branch #1171. |
|
For master, I would probably just drop 5.10. Upstream already defaulted it to 6.1 so I reckon that is reasonable. @Jessseee could you follow up with that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to see support for the Raspberry Pi Camera Module v3 which uses the imx708 sensor. Therefore, I added the required device tree overlay and config. I am not able to test this right now but it would be great if an admin could verify this patch.