Enable to support USB boot #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agherzan
requested changes
May 15, 2023
There was a problem hiding this comment.
Thanks for this, @harunobukurokawa. I've left some comments and we also need a documentation update on this.
harunobukurokawa
force-pushed
the
sandbox/support-usbboot
branch
from
50909af to
daf7e0c
Compare
agherzan
requested changes
Jun 15, 2023
harunobukurokawa
force-pushed
the
sandbox/support-usbboot
branch
2 times, most recently
from
3532001 to
fedae88
Compare
kraj
reviewed
Aug 20, 2023
harunobukurokawa
force-pushed
the
sandbox/support-usbboot
branch
from
fedae88 to
e36c072
Compare
agherzan
approved these changes
Sep 19, 2023
agherzan
requested changes
Nov 14, 2023
There was a problem hiding this comment.
@harunobukurokawa, this looks good to me now. Could you rebase your commits and update the PR description to match the current changes?
harunobukurokawa
changed the title
The Raspberry Pi 4 board can boot the image from USB memory. But current meta-raspberrypi supports only SD boot. This commit allows switching SD boot to other device. For example, if you want to use USB boot, please define the following parameters in your conf/local.conf file. CMDLINE_ROOT_PARTITION = "/dev/sda2" BOOT_MEDIA = "usb" v4: Update extra-build-config.md to explain more detail for new variable. v3: Changed variable name to "BOOT_MEDIA" (was "BOOT_DEVTIPE"). v2: Set existing microSD parameter as default. User can overwrite some parameters. Signed-off-by: Harunobu Kurokawa <[email protected]>
harunobukurokawa
force-pushed
the
sandbox/support-usbboot
branch
from
00c7b0f to
b522aba
Compare
|
@agherzan I rebased and push my commit. |
agherzan
approved these changes
Nov 23, 2023
kraj
approved these changes
Nov 23, 2023
|
@kraj I requested that so that we don't have to maintain values from uboot/kernel perspective. Indeed, a UX compromise. I'll leave it as such for now. We could have a better variable in the future if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raspberry Pi 4 board can boot the image from USB memory. But, current meta-raspberrypi supports only SD boot.
This commit allows switching SD boot to other device. For example, if you want to use USB boot, please define the following parameters in your conf/local.conf file.
CMDLINE_ROOT_PARTITION = "/dev/sda2"
BOOT_MEDIA = "usb"
- What I did
I checked
- How I did it
This commit is a proposal then I wrote some description in commit message