Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpi-config: Upgrade to tip of tree #1247

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

leon-anavi
Copy link
Contributor

@leon-anavi leon-anavi commented Nov 17, 2023

Upgrade to the latest version of the repository which includes the following improvements of the template for config.txt:

  • update revision and date stamp
  • additon of dtoverlay
  • general updates

This work was sponsored by GOVCERT.LU.

- What I did

Upgrade to the latest version of https://github.com/Evilpaul/RPi-config

- How I did it

While working on #1237 I noticed that recipe rpi-config uses an older version and decided to upgrade the template for config.txt to the latest available version. The primary reason is that in the new version the date at the beginning of config.txt has been changed for Revision 16, 2013/06/22 to Revision 17, 2021/08/15. Obviously there have been many additions in general to config.txt since 2013 so it is better to use a newer date.

Upgrade to the latest version of the repository with includes the
following improvements of the template for config.txt:

- update revision and date stamp
- additon of dtoverlay
- general updates

This work was sponsored by GOVCERT.LU.

Signed-off-by: Leon Anavi <[email protected]>
Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agherzan agherzan enabled auto-merge (rebase) November 17, 2023 12:43
@agherzan agherzan merged commit 6008249 into agherzan:master Nov 17, 2023
18 checks passed
@holagvk
Copy link

holagvk commented Nov 18, 2023

@agherzan / @leon-anavi The latest revision of rpi-config removes a lot of configurations (e.g. start_x) in this patch: Evilpaul/RPi-config@78181ee

So, this PR may break meta-raspberrypi configurations in https://github.com/agherzan/meta-raspberrypi/blob/master/recipes-bsp/bootfiles/rpi-config_git.bb (e.g., VIDEO_CAMERA will no longer be able to set start_x=1)

Maybe we should revert this commit 6008249 ?

@leon-anavi
Copy link
Contributor Author

@holagvk good point. Wouldn't it be better to identify the missing configurations that are still needed and add them to https://github.com/Evilpaul/RPi-config ?

On Monday I will try to find them by comparing do_deploy of rpi-config_git.bb to the current default config.txt from https://github.com/Evilpaul/RPi-config.

@leon-anavi
Copy link
Contributor Author

@holagvk, I checked all sed commands from rpi-config.bb against the latest config.txt template. I wasn't able to identify any other missing configurations apart from the one you found. So I created a GitHub pull request to reintroduce start_x to the config.txt template: Evilpaul/RPi-config#8

@agherzan
Copy link
Owner

This shows an issue with this approach - we rely on upstream content for our configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants