libcamera-apps: fix build with libcamera-0.2.0 #1273
Merged
+280
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it's failing to build since the upgrade in: https://git.openembedded.org/meta-openembedded/commit/?id=711c6fbce39df685225bca081c5f42bae2de658b * fixes ../git/core/libcamera_app.cpp: In member function 'void LibcameraApp::ConfigureViewfinder()': ../git/core/libcamera_app.cpp:327:25: error: 'class libcamera::CameraConfiguration' has no member named 'transform' 327 | configuration_->transform = options_->transform; | ^~~~~~~~~ * be aware that the repository and libraries were removed in 1.4.0 version with: raspberrypi/rpicam-apps@0ca9f41 but I'll leave that change to someone actually using this, I was just fixing the build issue found in world builds * tweak FILES to package library symlink without "lib" prefix to fix: ERROR: libcamera-apps-1.4.2+git-r0 do_package: QA Issue: libcamera-apps: Files/directories were installed but not shipped in any package: /usr/lib/rpicam_app.so Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. libcamera-apps: 1 installed and not shipped files. [installed-vs-shipped] Signed-off-by: Martin Jansa <[email protected]>
agherzan
approved these changes
Feb 1, 2024
|
Thanks! Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's failing to build since the upgrade in: https://git.openembedded.org/meta-openembedded/commit/?id=711c6fbce39df685225bca081c5f42bae2de658b
fixes ../git/core/libcamera_app.cpp: In member function 'void LibcameraApp::ConfigureViewfinder()': ../git/core/libcamera_app.cpp:327:25: error: 'class libcamera::CameraConfiguration' has no member named 'transform'
327 | configuration_->transform = options_->transform;
| ^~~~~~~~~
be aware that the repository and libraries were removed in 1.4.0 version with: raspberrypi/rpicam-apps@0ca9f41 but I'll leave that change to someone actually using this, I was just fixing the build issue found in world builds
tweak FILES to package library symlink without "lib" prefix to fix: ERROR: libcamera-apps-1.4.2+git-r0 do_package: QA Issue: libcamera-apps: Files/directories were installed but not shipped in any package: /usr/lib/rpicam_app.so Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. libcamera-apps: 1 installed and not shipped files. [installed-vs-shipped]