-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpi-base: Added missing HiFiBerry #1284
Conversation
Is this a backport from main? If not, why is this kirkstone-specific? |
It's not a backport, because on main branch you don't have it. I'm working on kirkstone branch and it's a reason. It could be applied to any branch with kernel 5.10 or newer. I didn't test it with older kernels, but some dtbo files can be not available there. |
In that case, I would like for this to be pushed against main first to avoid feature divergence on maintenance branches. |
@kluszon Could you refresh this MR by recreating the branch with the cherry-pick of the commit you've prepared for master? This will kick the gears here and run the CI for kirkstone too.l |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Thanks.
@kluszon the builds fail with: | make[1]: *** No rule to make target 'arch/arm/boot/dts/overlays/hifiberry-amp4pro.dtbo'. Stop. |
Your kernel doesn't have the file. I compiled it locally without any problem. What should I do with it? |
I wish I had a kernel :) |
The only I can do is remove the problematic amp4pro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only I can do is remove the problematic amp4pro.
That should work. Could you:
- rework the removal commit to match the contribution patch format - https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html
- rebase on latest tip
Thanks.
51a75b9
to
0de10fb
Compare
There is anoter hifiberry hat, for which there is currently no overlay added to the build, so let's add it: hifiberry-dacplusadcpro.dtbo Signed-off-by: Pascal Huerst <[email protected]>
Added support for missing HiFiBerry AMP100, AMP3, AMP4 Pro, DAC+ ADC Pro, DAC+ DSP, DAC+ HD, Digi Pro. Signed-off-by: Michał Kluska <[email protected]>
Removed hifiberry amp4pro. Signed-off-by: Michał Kluska <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…Pro, DAC+ DSP, DAC+ HD, Digi Pro.
- What I did
Added missing support for HiFiBerry AMP100, AMP3, AMP4 Pro, DAC+ ADC Pro, DAC+ DSP, DAC+ HD, Digi Pro.
- How I did it
Add right lines to rpi-base.inc. Changes were tested and works fine with the branch.
Connected also with issue #1168