Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hifiberry-dacplusadc overlay #1286

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

JDavidsson
Copy link
Contributor

Add hifiberry-dacplusadc.dtbo that was missing from the list.

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thanks for your contribution. Could you please follow the project's contribution guidelines? https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html Checking the git history will give you examples relevant to that specific file.

@JDavidsson
Copy link
Contributor Author

Hi, sorry about that. Updated the commit message, hope it suffices.

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agherzan agherzan enabled auto-merge (rebase) March 18, 2024 12:24
auto-merge was automatically disabled March 18, 2024 12:31

Head branch was pushed to by a user without write access

@JDavidsson
Copy link
Contributor Author

Saw that the "DCO" failed on the wrong sign-off name. I amended it.

@kraj
Copy link
Collaborator

kraj commented Mar 18, 2024

Hi, sorry about that. Updated the commit message, hope it suffices.

it would be good if you rebased you branch and removed local merge commits to keep the public repo history clean, we just need patch commits

Add support for HiFiBerry DAC+ ADC.

Signed-off-by: jdavidsson <[email protected]>
Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@agherzan agherzan enabled auto-merge (rebase) March 27, 2024 10:43
@agherzan agherzan merged commit d072cc8 into agherzan:master Mar 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants