Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raspberrypi-firmware: Resort to github APIs for tarballs #1298

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

kraj
Copy link
Collaborator

@kraj kraj commented Mar 20, 2024

The firmware repo is huge ( 36G ) to clone is onerous using shallow clone tarballs require them to be pre-populated at some mirror which we don't have. Third option is to let github provide the tarball, there is concern that tarballs might change the compression etc and thus checksum would change that is something github would communicate to users in advance [1]

Therefore this is the best solution for us right now.

Also upgrade to latest while here and drop PR settings

[1] https://docs.github.com/en/repositories/working-with-files/using-files/downloading-source-code-archives#stability-of-source-code-archives

- What I did

- How I did it

@kraj kraj marked this pull request as ready for review March 20, 2024 01:45
@kraj kraj changed the title raspberrypi-firmware: Resord to github APIs for tarballs raspberrypi-firmware: Resort to github APIs for tarballs Mar 20, 2024
@shr-project
Copy link
Contributor

I think the previous firmware update broke picamera-libs:
do_install: install: cannot stat 'picamera-libs/20240312/git/opt/vc/lib/*.so': No such file or directory
do_populate_lic: ERROR: QA Issue: lib32-picamera-libs: LIC_FILES_CHKSUM points to an invalid file: picamera-libs/20240312/git/opt/vc/LICENCE [license-checksum]

I don't use picamera-libs nor python3-picamera (which depends on picamera-libs), aren't they replaced by libcamera stuff?

#1292 probably won't fix it as well, neither does #1294

@kraj
Copy link
Collaborator Author

kraj commented Mar 21, 2024

I think picamera should be replaced with https://github.com/raspberrypi/picamera2 since it supports 64bit as well as 32bit, unlike picamera which only works with precompiled userland VC drivers and 32bit only.

kraj added 3 commits March 20, 2024 22:37
The firmware repo is huge ( 36G ) to clone is onerous
using shallow clone tarballs require them to be pre-populated
at some mirror which we don't have. Third option is to let
github provide the tarball, there is concern that tarballs
might change the compression etc and thus checksum would change
that is something github would communicate to users in advance [1]

Therefore this is the best solution for us right now.

Also upgrade to latest while here and drop PR settings

[1] https://docs.github.com/en/repositories/working-with-files/using-files/downloading-source-code-archives#stability-of-source-code-archives

Signed-off-by: Khem Raj <[email protected]>
This file is now used to fetch binary blobs used by picamera and
vc library recipes, which are only compatible with 32bit userspace
Perhaps we need to sunset these recipe as some point and repace
with alternatives like picamera2 which is built on top of libcamera
and works on both 32bit and 64 bit

rpi-bootfiles is fetching from latest firmware.

Signed-off-by: Khem Raj <[email protected]>
@kraj
Copy link
Collaborator Author

kraj commented Mar 21, 2024

I think the previous firmware update broke picamera-libs: do_install: install: cannot stat 'picamera-libs/20240312/git/opt/vc/lib/*.so': No such file or directory do_populate_lic: ERROR: QA Issue: lib32-picamera-libs: LIC_FILES_CHKSUM points to an invalid file: picamera-libs/20240312/git/opt/vc/LICENCE [license-checksum]

I don't use picamera-libs nor python3-picamera (which depends on picamera-libs), aren't they replaced by libcamera stuff?

#1292 probably won't fix it as well, neither does #1294

I have separated 32bit only recipe needs from rpi-bootfiles and that should fix the issue.

@paolobarbolini
Copy link

I'm wandering whether --filter=blob:none could fix the issue, if bitbake supports passing that flag. For me it took 20 seconds to clone the repo from scratch and the entire directory is about 480 MB

@kraj
Copy link
Collaborator Author

kraj commented Mar 23, 2024

I'm wandering whether --filter=blob:none could fix the issue, if bitbake supports passing that flag. For me it took 20 seconds to clone the repo from scratch and the entire directory is about 480 MB

sadly, bitbake fetcher does not accept git commands directly, it has to be modified for that.

@kraj
Copy link
Collaborator Author

kraj commented Mar 23, 2024

@agherzan we need to merge this quickly, or else everyone will be fetching ~36G of firmware repo and break the internet :)

@nandra
Copy link
Contributor

nandra commented Mar 26, 2024

@agherzan can you please merge this. It's blocking me to use meta-raspberrypi master branch for test build. Thanks.

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merged!

@agherzan agherzan merged commit ec06e94 into agherzan:master Mar 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants