Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests based on panda3d bug when chosing the device #146

Open
ElliotMaitre opened this issue Mar 13, 2024 · 0 comments
Open

Tests based on panda3d bug when chosing the device #146

ElliotMaitre opened this issue Mar 13, 2024 · 0 comments

Comments

@ElliotMaitre
Copy link
Collaborator

ElliotMaitre commented Mar 13, 2024

When running test on a device with cuda available, we want to test that it both works on GPU and CPU. In this case, different problem arise when running the tests. Problematic tests are test_renderer_panda3d.py and test_megapose_inference.py.

In order to make the test run on a chosen device, I tried to modify some functions in the following way :

load_named_model, load_pose_models, Panda3dBatchRenderer, Panda3dSceneRenderer, App (i.e. Panda3d App) and the worker_loop of Panda3dBatchRenderer take device as input. Then, the different lines involving code such as if torch.cuda.is_available() is changed to use the selected device. This change seems to cause some issues :

  • If any test involving pybullet is run before a test involving panda3d, the test bug and a Python aborted error occurs. The current workaround is to change the test order, since the usage of both pybullet and panda3d in the same run is currently not possible, except in the test environment. In this setup, test_megapose_inference.py runs
  • Panda3dSceneRenderer related tests are passing. Panda3dBatchRenderer suffers a Python Aborted error. The issue arise in _init_renderer, line 331 renderer_process.start()

For now, we decided to test only on GPU if a GPU is available, and on CPU if not.

@ElliotMaitre ElliotMaitre changed the title Tests based on panda3d bug when run after a test using pybullet Tests based on panda3d bug Mar 21, 2024
@ElliotMaitre ElliotMaitre changed the title Tests based on panda3d bug Tests based on panda3d bug when chosing the device Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant