-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get watchdog interval #6
Comments
Sounds like a good idea! Any interested in submitting a PR? |
Mr0grog
added a commit
to Mr0grog/ruby-sdnotify
that referenced
this issue
Jun 26, 2024
This adds a `watchdog_interval` method as well as tests for it and for `watchdog?` (which previously had no tests). I also took the liberty of revising the docs for `watchdog?` to (I hope) be a little clearer. Fixes agis#6.
Done! #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was helping a friend implement watchdog notifications, and noticed that, unlike
sd_watchdog_enabled(3)
, this gem doesn’t have a way to get the configured watchdog interval. Instead, pretty much every Ruby gem or app I’ve seen use this has to implement the same pattern:It would be much more convenient (and require less digging around to learn the environment variables) if this gem exposed a method to get the watchdog interval:
Ideally, I think this would:
Return 0 (or maybe -1?) if the watchdog is not expecting notifications (that is, if
SdNotify.watchdog?
would have returned false).Return the number of seconds as a float instead of the number of microseconds as an integer, since almost all use cases will involve doing this anyway.
The text was updated successfully, but these errors were encountered: