Added conda env segment

[Gigitsu]

No description provided.

[drorata]

I guess you also need to add

changeps1: False

to .condarc.

[MichaelAquilina]

why not check this first and then use elif to explicitly fall back? This will make sure that this is the first choice if changes are made in the future.

[drorata]

@MichaelAquilina I assume you're right. As this is not my PR I cannot say for sure. But it makes sense.

[Gigitsu]

Do you mean something like this?

if [[ -n $CONDA_DEFAULT_ENV ]]; then
  env=$CONDA_DEFAULT_ENV
elif [[ -n $VIRTUAL_ENV ]]; then
  env=$VIRTUAL_ENV
fi

[MichaelAquilina]

yes :) @Gigitsu

[MichaelAquilina]

also, its good practice to wrap your variables in quotes, otherwise spaces might give you wrong results:

if [[ -n "$CONDA_DEFAULT_ENV" ]]; then
  env="$CONDA_DEFAULT_ENV"
elif [[ -n "$VIRTUAL_ENV" ]]; then
  env="$VIRTUAL_ENV"
fi

[Gigitsu]

Ok, it make sense to me too :)

[Gigitsu]

@MichaelAquilina thank you for the advices, I've made the changes and updated the pull request

[Gigitsu]

@drorata thank you for your interest.

I don't thinks it is necessary to set changeps1 to false, I have that property to true and it works fine :)

[drorata]

@Gigitsu I had to disable changeps1 in my .condarc...

[Gigitsu]

@drorata what behaviour do you have with changeps1 enabled?

[drorata]

The first (non colored) part comes from Conda's patching of $PS1. At least this is what I understand.

[drorata]

I can confirm that also on another system I had to disable changeps1.

[MichaelAquilina]

looks good. But probably worth adding a comment explaining why this code exists :)

[apjanke]

kubernetes is unrelated to conda. Want to break this out to a separate PR?

[apjanke]

If y'all are interested, I added support for this over on my AgnosterJ fork.

[HaHeho]

I can confirm that also on another system I had to disable changeps1.

Same here. I mean this modification takes no influence on the on the .condarc configuration. Although it is clearly desired to have latter disabled if agnoster should show the env. But I have no idea if that is reasonable to implement.

BTW, I would be very happy to get this merged and integrated (if the requested changes could be made).

[Gigitsu]

I can confirm that also on another system I had to disable changeps1.

Same here. I mean this modification takes no influence on the on the .condarc configuration. Although it is clearly desired to have latter disabled if agnoster should show the env. But I have no idea if that is reasonable to implement.

BTW, I would be very happy to get this merged and integrated (if the requested changes could be made).

Ok, I've created another pull request ( #148 ) for k8s context, do you prefer a new pr for this to or can I just modify this?

[michcio1234]

Anything happening here? :)

[ehartford]

Can this go in please?

[damonhayhurst]

Ditto

[Gigitsu]

Hi @MichaelAquilina, can I do something to get this PR approved? If not, we can go ahead and close it.

[tuhinsharma121]

@Gigitsu thanks for the work. It works perfectly in my system. I dont understand why its not merged yet. I had to use your fork. Here I have attached a screenshot.