Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ag. response eats exceptions thrown while calculating attributes #576

Open
kbareja opened this issue Aug 16, 2022 · 1 comment
Open

Ag. response eats exceptions thrown while calculating attributes #576

kbareja opened this issue Aug 16, 2022 · 1 comment

Comments

@kbareja
Copy link

kbareja commented Aug 16, 2022

(v 4.10)

When I defined new attribute ( e.g. `AgEntity.overlay(Media.class).redefineAttribute("attr", String.class, this::calculate) and my attribute calculating function throws an exception (e.g. Null pointer) - there is no information about the problem anywhere in logs and server just returns unfinished list of data.

andrus added a commit that referenced this issue Aug 17, 2022
andrus added a commit that referenced this issue Aug 17, 2022
@andrus
Copy link
Contributor

andrus commented Aug 17, 2022

As the unit tests committed above show, the issue doesn't happen with small responses. It seems to happen when an encoder has a chance to flush some data to the client, and then the error happens. So the code has no chance to change the HTTP status or un-flush the partial content.

Still need to build a test for this case to see what we can do.

stariy95 pushed a commit that referenced this issue Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants