Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically Linked version of zlib.dll / librdkafka.dll #92

Open
wangjia184 opened this issue Dec 7, 2016 · 2 comments
Open

Statically Linked version of zlib.dll / librdkafka.dll #92

wangjia184 opened this issue Dec 7, 2016 · 2 comments

Comments

@wangjia184
Copy link

I get the NuGet package and found that the zlib.dll is not statically linked to the runtime.

image

This involves an extra runtime on deployment. Can we use a statically linked version of zlib.dll in the NuGet package?

Or even better, statically link to the zlib in librdkafka.dll to avoid the extra dependency on zlib.dll.
@ah-
Copy link
Owner

ah- commented Dec 9, 2016

Yes, that'd be really nice and make it easier to use.

This build is done with https://github.com/ah-/librdkafka-build, want to give it a go? I'd love to merge a PR.

@wangjia184
Copy link
Author

PR is created here : https://github.com/ah-/librdkafka-build/pull/1

Please have some test, if everything is ok. Could you please update NuGet package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ah- @wangjia184