Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the WP8.1 / IE11 bug on the JavaScript library. IE11 has in the… #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LuigiQuarta
Copy link

… user agent both android and iphone and that caused it to be detected in a wrong way. Here the details: http://www.neowin.net/news/ie11-fakes-user-agent-to-fool-gmail-in-windows-phone-81-gdr1-update

@ahand
Copy link
Owner

ahand commented Aug 10, 2015

@Zoimaru:
Thanks for making some commits. I was aware of this issue and was feeling ambivalent about it... As a result, I didn't address it in the last round of updates.

When making a fix, it's important to apply consistent logic across the code libraries. You correctly used the DetectWindowsPhone() method in the JavaScript library. However, you used a different method for the Java library.

We must also make consistent updates across the entire MobileESP code base so that the behavior is as consistent as possible across programming language.

Would you like to take a stab at applying the code update to the other libraries, too?

@LuigiQuarta
Copy link
Author

@ahand
I've made the change consistent for the Java version using detectWindowsPhone10() instead the user agent check, I didn't noticed the method on Java the first time, my fault!

I've updated also the Python and PHP files, about the ASP and CPP I think is better someone else help on this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants