Skip to content

Commit

Permalink
Make managedResourceGroup optional (Azure#526)
Browse files Browse the repository at this point in the history
* Make managedResourceGroup optional
  • Loading branch information
mociarain authored Sep 5, 2024
1 parent 55e87c7 commit a9a8edb
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ model ProxyProfile {
/** Azure specific configuration */
model PlatformProfile {
/** Resource group to put cluster resources */
managedResourceGroup: string;
managedResourceGroup?: string;

/** ResourceId for the subnet used by the control plane */
subnetId: SubnetResourceId;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1952,7 +1952,6 @@
}
},
"required": [
"managedResourceGroup",
"subnetId",
"networkSecurityGroupId"
]
Expand Down
2 changes: 1 addition & 1 deletion internal/api/hcpopenshiftcluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ type ProxyProfile struct {
// PlatformProfile represents the Azure platform configuration.
// Visibility for the entire struct is "read create".
type PlatformProfile struct {
ManagedResourceGroup string `json:"managedResourceGroup,omitempty" validate:"required_for_put"`
ManagedResourceGroup string `json:"managedResourceGroup,omitempty"`
SubnetID string `json:"subnetId,omitempty" validate:"required_for_put"`
OutboundType OutboundType `json:"outboundType,omitempty" validate:"omitempty,enum_outboundtype"`
//TODO: Is nsg required for PUT, or will we create if not specified?
Expand Down
6 changes: 3 additions & 3 deletions internal/api/v20240610preview/generated/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a9a8edb

Please sign in to comment.