Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails parsing row with spreadsheetDrawing #22

Open
seeker25 opened this issue Nov 3, 2017 · 2 comments
Open

Fails parsing row with spreadsheetDrawing #22

seeker25 opened this issue Nov 3, 2017 · 2 comments
Labels

Comments

@seeker25
Copy link

seeker25 commented Nov 3, 2017

Tries to parse the row number for an image http://schemas.openxmlformats.org/drawingml/2006/spreadsheetDrawing

image

This causes an exception when trying to get rows.

Would recommend filtering out spreadsheetDrawing rows. Unless these are to be parsed.

@seeker25 seeker25 changed the title Tries to parse cell Fails parsing row with spreadsheetDrawing Nov 3, 2017
@Sibz
Copy link
Contributor

Sibz commented Nov 3, 2017

I can look into this on Tuesday

Sibz added a commit to Sibz/FastExcel that referenced this issue Nov 13, 2017
@Sibz
Copy link
Contributor

Sibz commented Nov 13, 2017

Just looking into this now, sorry for the delay. I am thinking there are other special cases other than spreadsheetDrawing that produce rows with no cells.
Perhaps another way is to filter out rows with no cells, essentially treating them as if they weren't there, after-all this library is for fast access of data. The downside would be there is no access to the underlying data if in the rare case it was wanted. For example, the number 23 above refers to a separate file where the data is. I imagine anyone using this library won't be needing to reconstruct drawings, graphs, etc..

I'll put that to @mrjono1 to decided if this is the right approach to take.

Meanwhile if that is what you need, you can find it in my branch:
https://github.com/Sibz/FastExcel/tree/Skip-Empty-Rows

Let me know how test goes.

Sibz added a commit to Sibz/FastExcel that referenced this issue Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants