Add env var to disable GAR blob bypass logic and let the proxy handle artifact downloads #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… artifact-downloads
maheperera
force-pushed
the
allow-blob-proxying
branch
from
d657c8b to
c3f4132
Compare
maheperera
commented
Feb 12, 2025
| } | ||
|
|
||
| updateTokenEndpoint(resp, origHost) | ||
| return resp, nil | ||
| } | ||
|
|
||
| // updateTokenEndpoint modifies the response header like: | ||
| // Www-Authenticate: Bearer realm="https://auth.docker.io/token",service="registry.docker.io" |
There was a problem hiding this comment.
@ahmetb, which formatter do you use? I'd like to configure mine similarly to avoid making unnecessary changes like this.
maheperera
force-pushed
the
allow-blob-proxying
branch
from
c3f4132 to
a43eec9
Compare
|
@maheperera I'd recommend forking, this is not a mainline feature that most users would need. |
|
@ahmetb Sure, will close this PR now. Thanks heaps for a really useful repo 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional env var
DISABLE_GAR_BLOB_BYPASSwhich can be used to force the blob downloads through the proxy.This is required in scenarios where general internet access is restricted and ALL traffic must flow through the proxy server.