Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle support + AAR on maven? #21

Open
danielesegato opened this issue Jan 29, 2014 · 26 comments
Open

Gradle support + AAR on maven? #21

danielesegato opened this issue Jan 29, 2014 · 26 comments

Comments

@danielesegato
Copy link

Hi,

can you add support from gradle and publish as artifact on maven central?

you can follow this guide:
http://gmariotti.blogspot.it/2013/09/publish-aar-file-to-maven-central-with.html

@ahorn
Copy link
Owner

ahorn commented Jan 29, 2014

Hi Daniele,

I'd be happy to accept a "git pull" request on this.

With kind regards,
Alex

@danielesegato
Copy link
Author

Hi @ahorn

I can can implement part of this stuff and do a pull request.

But there's something I can't do and YOU have to do.

specifically:

  • creating a sonatype account
  • creating a sonatype ticket and reply to it the first time
  • creating a PGP key for you and configuring your system to use it

If you are ok with this I can provide the "code-part" of the thing as and do a pull request to you.

Regards,
Daniele

@ahorn
Copy link
Owner

ahorn commented Feb 11, 2014

Thanks Daniele for looking into this. I am generally open to your suggestion. Forgive me, I'm not a deployment expert so I have a few questions:

  • Does the public part of the PGP key (and hence the private key) have to remain fixed once the project is deployed to Sonatype? Or is it more like having (say) my Github SSH key that I can easily regenerate if need be?
  • How does the current deployment of android-rss in your setting look like?
  • What benefits would a deployed Sonatype package bring in your setting?
  • Are there any fees, whether hidden or not?

With kind regards,
Alex

@warmwaffles
Copy link

Any updates on this?

@ahorn
Copy link
Owner

ahorn commented Oct 6, 2014

@warmwaffles

I am afraid, android-rss is currently only still available through Git. The comments from February sought to better understand the role of Sonatype packages in the workflow of people who are using android-rss. Perhaps you could shed more light on it?

I am particularly nervous about the signing and the deployment steps.

@warmwaffles
Copy link

@ahorn what's there to be nervous about? I haven't done deploys but I think it would be worth while to learn.

@ahorn
Copy link
Owner

ahorn commented Oct 6, 2014

It's not an issue when it comes to learning about it. The issues have more to do with the things I bring up in February. If these are non issues, would you be willing to do it?

Alex

@warmwaffles
Copy link

Currently looking at how this can be accomplished. I am going to look at sonatype to see what costs there are if any. I have some other libraries I want to live there as well as maven.

@a1exus
Copy link

a1exus commented Mar 5, 2015

Is there any update on this? I'd like to use this library with my project via Gradle.

@ahorn
Copy link
Owner

ahorn commented Mar 6, 2015

I don't know whether @warmwaffles or @danielesegato have done this in the end.

@danielesegato
Copy link
Author

Personally I compiled and placed the library on my company private artifactory and used the dependency from there.

Still think the library, to be useful for most, has to be placed on maven central.

It's true the documentation about how to do this is very lacking, I invite you to push for a better documentation about this in the google products forum about gradle/android studio and or bug reports

@ahorn
Copy link
Owner

ahorn commented Mar 7, 2015

Thanks for the update, and the pointers in the right direction. I am glad you are finding android-rss useful.

If the grade+Android documentation is not that great, as you say, I think I'd prefer to rely on someone with more expertise on the deployment side of things because they are likely to be able to knock this out in a fraction of the time than me and it would give the project a more collective sense of ownership.

@a1exus
Copy link

a1exus commented Mar 9, 2015

@ahorn I'm very new to Android and Java and to access android-rss via Gradle (like nhaarman/ListViewAnimations) would make it super easy)

@ahorn
Copy link
Owner

ahorn commented Mar 9, 2015

@a1exus Okay. Could you please model a the build script after the one in the nhaarman/ListViewAnimations) setup?

@a1exus
Copy link

a1exus commented Mar 9, 2015

@ahorn haha, did I mention that I'm VERY new to this?) I wouldn't even know where to start.

@jitpack-io
Copy link
Contributor

Btw, it's very easy to publish GitHub repositories on JitPack.io as maven dependencies. Don't even need to upload anything. Here is android-rss already available: https://jitpack.io/#ahorn/android-rss/v1.0-rc1

@ahorn
Copy link
Owner

ahorn commented Apr 5, 2015

@jitpack-io, thank you very much! Could I ask @a1exus, @warmwaffles, @danielesegato to confirm that this fixes the issue. Once I get the okay, I update the README.

@danielesegato
Copy link
Author

Well.. That should work out.

I still would prefer a maven artifact but that allow including in the project as dependency so I would say it does solve the issue.

@ahorn
Copy link
Owner

ahorn commented Apr 7, 2015

Thanks @danielesegato. If you've (and preferably one other person) actually tried using the dependency in your own project(s) and it works, I'd suggest closing the issue.

@a1exus
Copy link

a1exus commented Apr 8, 2015

@ahorn I was able to add @jitpack-io repositories and dependencies to gradle, however since i'm new someone else should try it and verify as well.

@ahorn
Copy link
Owner

ahorn commented Apr 8, 2015

Thanks @a1exus. Anyone else?

@lucasfarre
Copy link

Excellent, I used JitPack with this library, and worked great! Thank you so much @ahorn and @jitpack-io !! Please add this trick in the README because it was really difficult to find it. Thanks again!

@ahorn
Copy link
Owner

ahorn commented Apr 9, 2015

Thank you very much, @lucasfarre, @a1exus @danielesegato for validating that the issue is solved. No check-sums are used to date as far as I can tell. So I trust that you've manually verified that the pulled in dependency is in fact what you'd expect?

@jitpack-io
Copy link
Contributor

@ahorn Hi! We run maven with -DcreateChecksums=true so checksums should be available:
https://jitpack.io/com/github/ahorn/android-rss/v1.0-rc1/android-rss-v1.0-rc1.jar.sha1

@ahorn
Copy link
Owner

ahorn commented May 10, 2015

@jitpack-io, thanks very much for #25.

@ahorn
Copy link
Owner

ahorn commented Oct 21, 2017

Hi @lucasfarre @danielesegato, @warmwaffles @jitpack-io

For some time now, I wanted to update the README with some contributor information, and references to projects/products that are using android-rss. If you are willing to share any of this information, please feel free to provide the following, or a subset thereof:

  • Your name and/or organization you would like to be mentioned;
  • The project name, or product, that is using android-rss.

Many thanks again for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants