Pin dycore, physics, and driver GFDL submodules to latest main
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
changed the title
mainmain
AnnaKwa
approved these changes
Nov 1, 2023
spencerkclark
added a commit
that referenced
this pull request
Nov 2, 2023
This PR ports the ability to override the surface radiative fluxes seen by the land surface model from the wrapper. This was split across two PRs originally in the case of FV3GFS: - ai2cm/fv3gfs-fortran#158 - ai2cm/fv3gfs-wrapper#244 This depends on the fortran changes made in: - NOAA-GFDL/SHiELD_physics#31 - NOAA-GFDL/atmos_drivers#31 which have now been merged, and incorporated into this repo via #11.
spencerkclark
added a commit
that referenced
this pull request
Nov 3, 2023
This PR ports the changes in ai2cm/fv3gfs-fortran#317 to the SHiELD wrapper, which give us finer grained control over the steps of the time loop related to the physics. It depends on NOAA-GFDL/atmos_drivers#30, which was merged upstream and incorporated into this repository in #11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dycore, physics, and driver NOAA-GFDL submodules in this repo to their latest
mainbranches. Now thatoverride_surface_radiative_fluxesflag togfdl_diag_registerNOAA-GFDL/atmos_drivers#31update_atmos_radiation_physicsinSHiELD/atmos_model.F90NOAA-GFDL/atmos_drivers#30cs_profilewheniv == -3NOAA-GFDL/GFDL_atmos_cubed_sphere#302have been merged, all the required features in SHiELD are in place to bring SHiELD-wrapper up-to-par with fv3gfs-wrapper.
Note that NOAA-GFDL/SHiELD_physics#31 made changes to the long names of some of the diagnostics output in our regression test, which required a checksum update.
I have also taken the liberty to remove the disclaimer from the README that states that changes to SHiELD are required to bring SHiELD-wrapper up-to-par with FV3GFS. That is no longer a limiting factor, and those remaining features are implemented in open PRs in this repo.