Port surface radiative flux override capability #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
force-pushed
the
diagnostics
branch
from
3c5af7c to
ba458d3
Compare
spencerkclark
force-pushed
the
override-radiative-fluxes
branch
2 times, most recently
from
573b791 to
fd5262b
Compare
6 tasks
spencerkclark
force-pushed
the
override-radiative-fluxes
branch
from
4030ca6 to
86eb6f7
Compare
spencerkclark
force-pushed
the
override-radiative-fluxes
branch
from
86eb6f7 to
d88b603
Compare
spencerkclark
force-pushed
the
override-radiative-fluxes
branch
from
d88b603 to
c1876b8
Compare
frodre
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
LGTM. Only thing I noticed is that the Fortran adjustments present in ai2cm/fv3gfs-fortran#158 are not linked to this PR for shield, so I assume the allocation changes are unnecessary or already exist over there?
spencerkclark
added a commit
that referenced
this pull request
Nov 3, 2023
This PR adds a dependabot configuration to track updates to the GFDL submodules contained in this repo. I have tried to configure it to check for updates to all the repos once a week, and if any are updated, open a PR updating them all as a group. The motivation behind this is that these repos are all interdependent, and so it is not uncommon for a change in one repo to require a change in another (and these updates are often made around the same time, e.g. the fortran changes required for #5). Unfortunately I'm not sure there is a great way of testing this, so we may have to try it out and tweak things as we go. Resolves #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the ability to override the surface radiative fluxes seen by the land surface model from the wrapper. This was split across two PRs originally in the case of FV3GFS:
This depends on the fortran changes made in:
override_surface_radiative_fluxesflag togfdl_diag_registerNOAA-GFDL/atmos_drivers#31which have now been merged, and incorporated into this repo via #11.