Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot zip and data files download without extension. #667

Closed
lladdy opened this issue Dec 17, 2023 · 1 comment · Fixed by #691
Closed

Bot zip and data files download without extension. #667

lladdy opened this issue Dec 17, 2023 · 1 comment · Fixed by #691
Assignees
@lladdy

Comments

@lladdy
Copy link
Contributor

lladdy commented Dec 17, 2023

ResponseContentDisposition needs to be passed to the url method and the filename set.
As demonstrated here: jschneier/django-storages#1342
@lladdy lladdy moved this to 📋 Backlog in General Tasks Dec 17, 2023
@lladdy
Copy link
Contributor Author

lladdy commented Dec 18, 2023

Relevant code added here:

aiarena-web/aiarena/api/arenaclient/views.py

Line 60 in 9edfdc4

return get_file_s3_url_with_content_disposition(obj.bot_zip, f"{obj.name}.zip")

@lladdy lladdy assigned lladdy and unassigned ipeterov Dec 20, 2023
@lladdy lladdy linked a pull request Dec 20, 2023 that will close this issue
Fix bot zip and data files download without extension #691
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in General Tasks Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lladdy lladdy

Labels
None yet
Projects
General Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bot zip and data files download without extension aiarena/aiarena-web
2 participants
@ipeterov @lladdy