From 2b162933d7b66326afc18415aa15bb78667fc89a Mon Sep 17 00:00:00 2001
From: Aido <aido@users.noreply.github.com>
Date: Thu, 6 Jun 2024 21:31:02 +0100
Subject: [PATCH] Implement cx_bn_gf2_n_mul Workaround that implements
 cx_bn_gf2_n_mul() in the LNS SDK until it is hopefully added as a syscall on
 LNS OS like all other Ledger devices Fixes LedgerHQ/nanos-secure-sdk#64

---
 include/ox_bn.h   | 28 ++++++++++++++++++
 src/cx_wrappers.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 100 insertions(+)

diff --git a/include/ox_bn.h b/include/ox_bn.h
index d300b7692..3e88862c8 100644
--- a/include/ox_bn.h
+++ b/include/ox_bn.h
@@ -1075,4 +1075,32 @@ SYSCALL cx_err_t cx_bn_next_prime(cx_bn_t n);
  */
 SYSCALL cx_err_t cx_bn_rng(cx_bn_t r, const cx_bn_t n);
 
+/**
+ * @brief Performs a multiplication over GF(2^n).
+ *
+ * @details *bn_r* must be distinct from *bn_a* and *bn_b*.
+ *
+ * @param[out] bn_r BN index for the result.
+ *
+ * @param[in]  bn_a BN index of the first operand.
+ *
+ * @param[in]  bn_b BN index of the second operand.
+ *
+ * @param[in]  bn_n BN index of the modulus.
+ *                  The modulus must be an irreducible polynomial over GF(2)
+ *                  of degree n.
+ *
+ * @param[in]  bn_h BN index of the second montgomery constant.
+ *
+ * @return          Error code:
+ *                  - CX_OK on success
+ *                  - CX_NOT_LOCKED
+ *                  - CX_INVALID_PARAMETER
+ *                  - CX_MEMORY_FULL
+ */
+WARN_UNUSED_RESULT cx_err_t cx_bn_gf2_n_mul(cx_bn_t       bn_r,
+                                            const cx_bn_t bn_a,
+                                            const cx_bn_t bn_b,
+                                            const cx_bn_t bn_n,
+                                            const cx_bn_t bn_h);
 #endif /* CX_BN_H */
diff --git a/src/cx_wrappers.c b/src/cx_wrappers.c
index db26f2621..993c2a738 100644
--- a/src/cx_wrappers.c
+++ b/src/cx_wrappers.c
@@ -113,3 +113,75 @@ uint32_t cx_crc32(const void *buf, size_t len)
 {
     return cx_crc32_update(CX_CRC32_INIT, buf, len);
 }
+
+// At some point this could/should be migrated to the OS
+// Meanwhile, it's implemented here
+cx_err_t cx_bn_gf2_n_mul(cx_bn_t       bn_r,
+                         const cx_bn_t bn_a,
+                         const cx_bn_t bn_b,
+                         const cx_bn_t bn_n,
+                         const cx_bn_t bn_h __attribute__((unused)))
+{
+    cx_err_t error = CX_OK;
+    uint32_t degree, nbits_a, nbits_b;
+
+    // Ensure bn_r is distinct from bn_a and bn_b
+    if (bn_r == bn_a || bn_r == bn_b) {
+        error = CX_INVALID_PARAMETER;
+        goto end;
+    }
+
+    // Calculate the degree of the modulus polynomial
+    CX_CHECK(cx_bn_cnt_bits(bn_n, &degree));
+    degree--;
+
+    CX_CHECK(cx_bn_cnt_bits(bn_a, &nbits_a));
+    CX_CHECK(cx_bn_cnt_bits(bn_b, &nbits_b));
+
+    // Ensure both operands are in field
+    if (degree < 1 || nbits_a > degree || nbits_b > degree) {
+        error = CX_INVALID_PARAMETER;
+        goto end;
+    }
+
+    // Preliminaries
+    cx_bn_t  bn_tempa, bn_copy;
+    uint32_t bit_indexb = 0;
+    size_t   nbytes;
+    bool     bit_set = 0;
+
+    CX_CHECK(cx_bn_nbytes(bn_n, &nbytes));
+    CX_CHECK(cx_bn_alloc(&bn_tempa, nbytes));
+    CX_CHECK(cx_bn_alloc(&bn_copy, nbytes));
+
+    CX_CHECK(cx_bn_copy(bn_tempa, bn_a));
+    CX_CHECK(cx_bn_set_u32(bn_r, (uint32_t) 0));
+
+    // Main loop for multiplication
+    if (nbits_a) {
+        while (nbits_b > bit_indexb) {
+            CX_CHECK(cx_bn_tst_bit(bn_b, bit_indexb, &bit_set));
+            if (bit_set) {
+                CX_CHECK(cx_bn_copy(bn_copy, bn_r));
+                CX_CHECK(cx_bn_xor(bn_r, bn_tempa, bn_copy));
+            }
+
+            CX_CHECK(cx_bn_shl(bn_tempa, 1));
+            CX_CHECK(cx_bn_tst_bit(bn_tempa, degree, &bit_set));
+
+            if (bit_set) {
+                CX_CHECK(cx_bn_copy(bn_copy, bn_tempa));
+                CX_CHECK(cx_bn_xor(bn_tempa, bn_n, bn_copy));
+            }
+
+            bit_indexb++;
+        }
+    }
+
+    // Clean up
+    CX_CHECK(cx_bn_destroy(&bn_tempa));
+    CX_CHECK(cx_bn_destroy(&bn_copy));
+
+end:
+    return error;
+}