Bump actions/artifact-upload to v4 #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
commented
Dec 15, 2023
danielhollas
commented
Dec 15, 2023
|
Thanks! I just noticed the update. It makes upload much faster! The test failed because of Marnik's machine was shutdown, now should build and test on arm64.
How much time it will save without compress? |
danielhollas
changed the title
Seems to save a lot. Even the lowest level of compression (lvl 1) is ~20s slower. Note the download-artifact still takes around 1 minute, and there are other extra steps (saving and loading Docker images) that make all this slower. My apologies, I have by accident pushed some commits on master, so I needed to merge this without approval. Please leave a review if you have any comments and I'll make a new PR. |
unkcpz
added a commit
that referenced
this pull request
Dec 18, 2023
This is a revert amendment of #419 which merged improperly with test commints. - The changes should significantly speed up artifact upload, see https://github.com/actions/upload-artifact#v4---whats-new - Also include the updates of `action/checkout` action to v4 - include fix the python version of running environment to `3.11`. - include the changes of removing paths change detection in `docker.yml` --------- Co-authored-by: Daniel Hollas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should significantly speed up artifact upload, see https://github.com/actions/upload-artifact#v4---whats-new
TODO: Probably we should turn off compression, see https://github.com/actions/upload-artifact#altering-compressions-level-speed-v-size