Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruff to 0.8 #186

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Bump ruff to 0.8 #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d531b
Bump ruff to 0.8.1
danielhollas Nov 28, 2024
8de1faf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ repos:
exclude: miscellaneous/structures/SiO2.xyz

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.6.9
rev: v0.8.1
hooks:
- id: ruff-format
exclude: ^docs/.*
- id: ruff
args: [--fix, --exit-non-zero-on-fix, --show-fixes]

Expand All @@ -27,11 +26,11 @@ repos:
- id: yamlfmt

- repo: https://github.com/sirosen/check-jsonschema
rev: 0.29.3
rev: 0.29.4
hooks:
- id: check-github-workflows

- repo: https://github.com/kynan/nbstripout
rev: 0.7.1
rev: 0.8.1
hooks:
- id: nbstripout
2 changes: 1 addition & 1 deletion tests_notebooks/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import pytest
import requests
import selenium.webdriver.support.expected_conditions as ec
from requests.exceptions import ConnectionError
from requests.exceptions import ConnectionError # noqa: A004
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff was complaining that ConnectionError shadows a builtin exception.

from selenium.webdriver.common.by import By
from selenium.webdriver.support.wait import WebDriverWait

Expand Down