Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Replace deprecated IOError with OSError #6441

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jun 1, 2024

Fixes #4082

PEP 3151 reworked the builtin exception hierarchy and IOError was deprecated (kept as an alias) in favor of OSError. The change was implemented in Python 3.3: https://peps.python.org/pep-3151

PEP 3151 reworked the builtin exception hierarchy and `IOError` was
deprecated (kept as an alias) in favor of `OSError`. The change was
implemented in Python 3.3: https://peps.python.org/pep-3151
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 44.15584% with 43 lines in your changes missing coverage. Please review.

Project coverage is 77.70%. Comparing base (ef60b66) to head (5520011).
Report is 112 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/orm/nodes/data/remote/base.py 9.10% 10 Missing ⚠️
src/aiida/transports/plugins/ssh.py 65.00% 7 Missing ⚠️
src/aiida/engine/daemon/execmanager.py 20.00% 4 Missing ⚠️
src/aiida/transports/plugins/local.py 77.78% 4 Missing ⚠️
src/aiida/common/folders.py 0.00% 3 Missing ⚠️
src/aiida/cmdline/commands/cmd_data/cmd_remote.py 0.00% 2 Missing ⚠️
src/aiida/engine/daemon/client.py 33.34% 2 Missing ⚠️
src/aiida/orm/utils/mixins.py 0.00% 2 Missing ⚠️
...tools/archive/implementations/sqlite_zip/writer.py 0.00% 2 Missing ⚠️
src/aiida/cmdline/commands/cmd_computer.py 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6441      +/-   ##
==========================================
+ Coverage   77.51%   77.70%   +0.19%     
==========================================
  Files         560      562       +2     
  Lines       41444    41716     +272     
==========================================
+ Hits        32120    32410     +290     
+ Misses       9324     9306      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sphuber sphuber merged commit 7f9129f into aiidateam:main Jun 1, 2024
20 of 21 checks passed
@sphuber sphuber deleted the fix/4082/replace-ioerror-with-oserror branch June 1, 2024 14:46
mikibonacci pushed a commit to mikibonacci/aiida-core that referenced this pull request Sep 3, 2024
PEP 3151 reworked the builtin exception hierarchy and `IOError` was
deprecated (kept as an alias) in favor of `OSError`. The change was
implemented in Python 3.3: https://peps.python.org/pep-3151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOError vs OSError
1 participant