Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use already defined job resource classes? #8

Open
giovannipizzi opened this issue Dec 16, 2021 · 0 comments
Open

Use already defined job resource classes? #8

giovannipizzi opened this issue Dec 16, 2021 · 0 comments

Comments

@giovannipizzi
Copy link
Member

We should limit the number of different JobResource subclasses used by different scheduler plugins, I think, because these make different schedulers behave differently and so it's harder for the user to know which resources we pass.

For this scheduler, we clearly need to specify the total number of cores.

Memory can probably be removed as discussed in #7

Do we need a different class, and in particular both num_mpiprocs and num_cores?
Or can we just reuse e.g. this below (ParEnvJobResource), simply specifying the tot_num_mpiprocs? (and a parallel_env, which is a string - I imagine this would be matched in the future to the name of the alloc on which you want to run - e.g. GPU vs CPU etc.).

https://github.com/aiidateam/aiida-core/blob/ff1318b485a8b803e115b78946cc4593fc661153/aiida/schedulers/datastructures.py#L177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant