-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
references is missing #17
Comments
Well, not in One just has to actually do it. |
Right. I didn't mean that we couldn't create a new Data class for references. It was more the fact that it doesn't exist yet, and will not exist for, e.g., the databases on Material Cloud's Archive, I guess? Or did I miss something in your link reference? As a note, I am aware that this repository should be a separate entity, but since it is closely related to exposing the Materials Cloud archive databases at the moment, I think it makes most sense to implement a solution that can work for them. |
Yes, you can attach source attributes to every We should probably discuss with @giovannipizzi @sphuber what is needed to make them compatible with what is needed in optimade & whether these should be updated/generalized. I think they are used so far only by the "DB importers/exporters". |
You are right, though, that it may be worth reconsidering the question whether replicating reference information on each node is the way to go. In the end, however, I guess we are talking about a few hundred bytes per node, which is manageable at the scale of DBs that AiiDA currently supports (~1 million nodes), so introducing some relation between nodes and a |
The
/references
endpoint is missing.Since references cannot be saved as a base Node in AiiDA databases, I suggest this endpoint utilizes a
mongomock
database, where the data is put into a JSON file, the path to which can be set in a central config file. Like what is proposed in #14.The text was updated successfully, but these errors were encountered: