Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #372

Merged
merged 17 commits into from
Dec 2, 2024
Merged

Improve test coverage #372

merged 17 commits into from
Dec 2, 2024
+367 −320

Conversation

superstar54
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.13861% with 28 lines in your changes missing coverage. Please review.

Project coverage is 85.89%. Comparing base (512d1a8) to head (ab113c1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_action.py 70.45% 13 Missing ⚠️
tests/utils/test_workchain.py 59.37% 13 Missing ⚠️
aiida_workgraph/engine/task_manager.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   81.59%   85.89%   +4.29%     
==========================================
  Files          65       70       +5     
  Lines        4896     4927      +31     
==========================================
+ Hits         3995     4232     +237     
+ Misses        901      695     -206
Flag Coverage Δ
python-3.11 85.83% <86.13%> (+4.29%) ⬆️
python-3.12 85.83% <86.13%> (+4.29%) ⬆️
python-3.9 85.89% <86.13%> (+4.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 force-pushed the improve_test_coverage branch 3 times, most recently from db8af58 to 8a5124b Compare December 2, 2024 09:13
@superstar54 superstar54 force-pushed the improve_test_coverage branch 2 times, most recently from 73d7212 to 4c316b7 Compare December 2, 2024 09:35
@superstar54 superstar54 linked an issue Dec 2, 2024 that may be closed by this pull request
Improve test coverage #324
Closed
@superstar54 superstar54 merged commit 7f87a26 into main Dec 2, 2024
15 checks passed
@superstar54 superstar54 deleted the improve_test_coverage branch December 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve test coverage
2 participants
@superstar54 @codecov-commenter