Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping or parity between WG UUIDs and aiida-core UUIDs #365

Open
GeigerJ2 opened this issue Nov 28, 2024 · 1 comment
Open

Mapping or parity between WG UUIDs and aiida-core UUIDs #365

GeigerJ2 opened this issue Nov 28, 2024 · 1 comment
Assignees

Comments

@GeigerJ2
Copy link
Contributor

GeigerJ2 commented Nov 28, 2024

Currently, the UUIDs obtained from WG (e.g., via WG.to_dict() for the parent WG, as well as the sub-tasks in the nested dictionary), and the UUIDs of the aiida-core objects, e.g., the WorkChainNodes and CalcJobNodes shown, for example, through verdi process list and verdi process show differ.

I think this can cause a lot of confusion (as it just did for me), so we should find a way to solve this. Either call the keys in the WG dictionary representation different (wg_uiid or sthg similar), overwrite the WG ones when the WG process finishes with the corresponding aiida-core UUIDs (maybe this is difficult), or assign the WG UUIDs to the aiida-core ProcessNodes when they are created during the execution of the workflow.

To be thought about.

@superstar54
Copy link
Member

In principle, when creating a WorkGraph, we don't need to assign a UUID to it. We assign the UUID only when saving it into the database. This means we can just use the UUID of the AiiDA process node as soon as we get the process node in the run() and submit() methods.

For the tasks, uuid is not needed, because inside WorkGraph, we always use the task's name as a reference. Also, in some cases (e.g., in a while loop), one task corresponds to multiple process nodes.

@GeigerJ2 GeigerJ2 self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants