Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible version of typing-extensions with those in aiida-core #294

Open
khsrali opened this issue Dec 5, 2024 · 5 comments
Open

Incompatible version of typing-extensions with those in aiida-core #294

khsrali opened this issue Dec 5, 2024 · 5 comments

Comments

@khsrali
Copy link
Contributor

khsrali commented Dec 5, 2024

Commit 3b9318c sets typing-extensions>=4.12,<5.dev0
while in aiida-core we have:
typing-extensions==4.6.3, for python 3.9
typing-extensions==4.6.3, for python 3.10
typing-extensions==4.6.3, for python 3.11
typing-extensions==4.8.0, for python 3.12

This makes the development very difficult,
@unkcpz, can you suggest a solution?

@unkcpz
Copy link
Member

unkcpz commented Dec 5, 2024

I think we just wait a bit, either after mosquito/aio-pika#649 included in a patch release and we can continue without any problem.

Meanwhile, I think the requirements.txt are outdated, after aiidateam/aiida-core#6640 everything will be clear! I'll merge it now. Let's see.

@unkcpz
Copy link
Member

unkcpz commented Dec 5, 2024

We release a new kiwipy with 0.8.5 which includes the pinning of aio-pika version that don't have this problem. So I think it will be all fine with aiida-core if requirements.txt all updated properly.

@khsrali
Copy link
Contributor Author

khsrali commented Dec 12, 2024

@unkcpz thanks a lot, I'm puzzled because after aiidateam/aiida-core#6640 typing_extensions is not listed as a dependency anymore.. but aiida-core still depend on it, how does it work?

@unkcpz
Copy link
Member

unkcpz commented Dec 12, 2024

I'm puzzled because after aiidateam/aiida-core#6640 typing_extensions is not listed as a dependency anymore.. but aiida-core still depend on it, how does it work?

I don't understand this, where you see it is a dependency? Will uv shows where the typing_extensions as a dependency comes from?

@khsrali
Copy link
Contributor Author

khsrali commented Dec 12, 2024

I open an issue in aiida-core where this new issue belongs, just to have it stashed in the right repository for future.
aiidateam/aiida-core#6663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants