Separate public / private interface. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the public and private interface, as detailed in issues aiidateam#41,42,25. The duplicated code from CpInputFile and PwInputFile has been moved into the common base, which was renamed and made private. The constants are now given as a SimpleNamespace, instead of defined at the top-level of their module. The reason for this is that we want to be compatible with adding version-specific constants later on. This could now be done by adding a 'get_constants' function that takes the QE version as input, and returns the SimpleNamespace of corresponding constants.
|
Of course I'm happy to re-review if you want to address the remaining points before |
Nah, I've made separate issues for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41, fixes #42
Separate the public / private interface and rename as discussed in #41
As discussed in #42, the duplicated code from
CpInputFileandPwInputFilehas been moved into the common base, which was renamed and made private.The constants are now given as a
SimpleNamespace, instead of defined at the top-level of their module. The reason for this is that we want to be compatible with adding version-specific constants later on. This could now be done by adding aget_constantsfunction that takes the QE version as input, and returns theSimpleNamespaceof corresponding constants.#25 is also related, but not completely fixed
Next steps:
rc1TODO for 2.0 release proper: