Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Для большей читаемости лучше gru.nodes_types(discretized_data).values() вынести в переменную. #54

Open
Roman223 opened this issue Mar 31, 2023 · 0 comments
Open

Для большей читаемости лучше gru.nodes_types(discretized_data).values() вынести в переменную. #54

Roman223 opened this issue Mar 31, 2023 · 0 comments
Labels
refactoring

Comments

@Roman223
Copy link
Collaborator 

          Для большей читаемости лучше gru.nodes_types(discretized_data).values() вынести в переменную.

И переработать в all([node_type in discrete_types for node_type in nodes_types])

Можно в целом вынести такую проверку в функцию вроде is_discrete - явно где-то ещё может понадобится.

Originally posted by @nicl-nno in #50 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
BAMT backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Roman223 @jrzkaminski