Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of Sphinx syntax #1162

Closed
jakob-keller opened this issue Aug 21, 2024 · 4 comments · Fixed by #1189
Closed

Improve use of Sphinx syntax #1162

jakob-keller opened this issue Aug 21, 2024 · 4 comments · Fixed by #1189
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jakob-keller
Copy link
Collaborator

          FWIW, there's a dedicated Sphinx role for files:
1. Download sources of the release of botocore you're trying to upgrade to, and the version of botocore that aiobotocore is currently locked to (see :file:`pyproject.toml`) and do a folder based file comparison of the botocore folders (tools like DiffMerge are nice).

Originally posted by @webknjaz in #1160 (comment)

@jakob-keller jakob-keller added the documentation Improvements or additions to documentation label Aug 21, 2024
@jakob-keller
Copy link
Collaborator Author

Also: #1160 (comment)

@webknjaz
Copy link
Member

When calling Sphinx, pass -n -W --keep-going and set default_role = 'any' in conf.py. This will reveal the problems that need to be addressed.

@jakob-keller
Copy link
Collaborator Author

There is also #879. Should conversion to markdown be prioritised over improving RST?

@webknjaz
Copy link
Member

Partially, maybe. You can still enforce strictness in Sphinx. And then, you need to fix the references regardless of which syntax is used.

Additionally, to support inclusion of Markdown files into the Sphinx docs, you'll need to plug MyST-parser there and convert the index document into Markdown (maybe a few more docs, too). I think I have an example of that in pip-tools.

So I'd probably make the conversion depend on everything else...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants