[PR #8920/5cf5db56 backport][3.11] Re-enable keep-alive on proxies (#…

…8939) **This is a backport of PR #8920 as merged into master (5cf5db5).** Co-authored-by: Sam Bull <[email protected]>
aio-libs · Aug 29, 2024 · 8173932 · 8173932
1 parent 1dc3cd6
commit 8173932
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/CHANGES/8920.misc.rst b/CHANGES/8920.misc.rst
@@ -0,0 +1 @@
+Enabled keep-alive support on proxies (which was originally disabled several years ago) -- by :user:`Dreamsorcerer`.
diff --git a/aiohttp/client_proto.py b/aiohttp/client_proto.py
@@ -62,9 +62,6 @@ def should_close(self) -> bool:
             or bool(self._tail)
         )
 
-    def force_close(self) -> None:
-        self._should_close = True
-
     def close(self) -> None:
         transport = self.transport
         if transport is not None:

diff --git a/aiohttp/connector.py b/aiohttp/connector.py
@@ -1376,11 +1376,6 @@ async def _create_proxy_connection(
             proxy_req, [], timeout, client_error=ClientProxyConnectionError
         )
 
-        # Many HTTP proxies has buggy keepalive support.  Let's not
-        # reuse connection but close it after processing every
-        # response.
-        proto.force_close()
-
         auth = proxy_req.headers.pop(hdrs.AUTHORIZATION, None)
         if auth is not None:
             if not req.is_ssl():