Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_cookies in client_reqrep.py has the same performance issue that was solved for the jar itself in #9204 #9520

Open
bdraco opened this issue Oct 21, 2024 · 3 comments
Open

update_cookies in client_reqrep.py has the same performance issue that was solved for the jar itself in #9204 #9520

bdraco opened this issue Oct 21, 2024 · 3 comments
Assignees
@bdraco
Labels
enhancement waiting-for-upstream We are waiting for an upstream change

Comments

@bdraco
Copy link
Member

bdraco commented Oct 21, 2024 •
edited
Loading

The cookies get recreated every time. I need to dig into the cookie code some more to see if we can avoid this

aiohttp/aiohttp/client_reqrep.py

Line 510 in d74e51b

if isinstance(value, Morsel):

#9204

Screenshot 2024-10-21 at 1 44 47 PM
@bdraco bdraco self-assigned this Oct 21, 2024
@bdraco
Copy link
Member Author

bdraco commented Oct 21, 2024

Screenshot 2024-10-17 at 9 55 31 PM

bdraco added a commit that referenced this issue Oct 24, 2024
@bdraco
Add some simple benchmarks
fa15ace 
This will get the ball rolling so we know
when we have solved #9520
@bdraco bdraco mentioned this issue Oct 24, 2024
Merged
@patchback patchback bot mentioned this issue Oct 25, 2024
Merged
@github-staff github-staff deleted a comment Oct 29, 2024
@bdraco
Copy link
Member Author

bdraco commented Nov 1, 2024

I think we have to wait for python/cpython#126157

@bdraco bdraco added the waiting-for-upstream We are waiting for an upstream change label Nov 1, 2024
@bdraco
Copy link
Member Author

bdraco commented Nov 1, 2024

If we don't find another solution by the time Python 3.14 is released, we can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdraco bdraco

Labels
enhancement waiting-for-upstream We are waiting for an upstream change
Projects
Sprint @ Man Group London Hackathon 2024, Nov 9
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdraco @Dreamsorcerer