Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WebSocket extension permessage-gzip #9933

Open
1 task done
jakob-keller opened this issue Nov 16, 2024 · 2 comments · May be fixed by #9934
Open
1 task done

Support for WebSocket extension permessage-gzip #9933

jakob-keller opened this issue Nov 16, 2024 · 2 comments · May be fixed by #9934

Comments

@jakob-keller
Copy link

Is your feature request related to a problem?

I cannot communicate with WebSocket servers that use the permessage-gzip extension.

Describe the solution you'd like

aiohttp should provide support for the WebSocket extension permessage-gzip.

Describe alternatives you've considered

I was unable to find any alternative Python WebSocket libraries that provide support for the permessage-gzip extension.

Related component

Client

Additional context

RFC 7692 [...] defines a framework for creating WebSocket extensions that add compression functionality to the WebSocket Protocol [...] and specifies one specific compression extension using the DEFLATE algorithm.

#2273 added initial support for RFC 7692 including the permessage-deflate extension.

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Nov 16, 2024

Searching "permessage-gzip" got me exactly 1 result, so this doesn't look like something that people are generally using.
But, I think the standard that defines this support is (as listed above) https://www.rfc-editor.org/rfc/rfc7692.html
So, if someone wants to implement it, we can take a look at supporting it.

@jakob-keller
Copy link
Author

Searching "permessage-gzip" got me exactly 1 result, so this doesn't look like something that people are generally using.

You are right. The server I need to talk to is part of a private preview API. I will ask the provider to consider changing the compression to permessage-deflate or making it optional.

But, I think the standard that defines this support is (as listed above) https://www.rfc-editor.org/rfc/rfc7692.html So, if someone wants to implement it, we can take a look at supporting it.

If the provider does not move away from permessage-gzip, I might be able to contribute to a PR at a later time.

@jakob-keller jakob-keller linked a pull request Nov 17, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants