This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 214
Avoid mutating the global Promise #135
Open
juanca
wants to merge
14
commits into
airbnb:master
Choose a base branch
from
juanca:copy-bluebird
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
50357b5
Backfill environment tests for Promise
juanca 0c9df79
Ensure environment setup does not pollute bluebird module
juanca b10b37d
Tidy up whitespace
juanca 63f6a01
Do not modify bluebird Promises
juanca d357426
Implement StrictPromise to restrict Bluebird Promise interface
juanca 62e1234
Use appropriate import variable name for StrictPromise
juanca 6ec54da
Fix specs: fulfillment callback uses resolve. rejected callback is se…
juanca 3081a25
Backfill specs: StrictPromise.resolve
juanca 8c3f894
Backfill specs: StrictPromise.reject
juanca 6512c80
`npm test` also runs test in nested folders
juanca be5309f
Fix specs: chai API issues => async test issues => ensure tests are …
juanca 2590dc5
Backfill specs: StrictPromise.race
juanca 9baf25d
Backfill specs: StrictPromise.all
juanca af9a5ed
Tidy up
juanca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import { assert } from 'chai'; | ||
import Promise from 'bluebird'; | ||
import '../src/environment'; | ||
|
||
|
||
describe('environment', () => { | ||
it('does not modify the Promise package', () => { | ||
assert.notStrictEqual(Promise, global.Promise); | ||
}); | ||
|
||
describe('global promise', () => { | ||
it('has ES6 methods', () => { | ||
assert.isFunction(global.Promise.prototype.then); | ||
assert.isFunction(global.Promise.prototype.catch); | ||
assert.isFunction(global.Promise.prototype.constructor); | ||
}); | ||
|
||
it('has ES6 static methods', () => { | ||
assert.isFunction(global.Promise.all); | ||
assert.isFunction(global.Promise.race); | ||
assert.isFunction(global.Promise.resolve); | ||
assert.isFunction(global.Promise.reject); | ||
assert.isFunction(global.Promise.cast); | ||
}); | ||
|
||
it('removes extraneous methods', () => { | ||
assert.isUndefined(global.Promise.promisifyAll); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. This is not supported until Node 4.
Is there preferred method to checking in a polyfill?