Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to prevent shipping same exception instance twice #36

Open
zachgoldstein opened this issue Feb 9, 2017 · 0 comments
Open

Tests to prevent shipping same exception instance twice #36

zachgoldstein opened this issue Feb 9, 2017 · 0 comments

Comments

@zachgoldstein
Copy link
Contributor

zachgoldstein commented Feb 9, 2017

So I see the notes about the global exception stack here:
https://github.com/airbrake/airbrake-python/blob/master/airbrake/notifier.py#L153

And later I see duplicate exception instances getting filtered out.
https://github.com/airbrake/airbrake-python/blob/master/airbrake/notifier.py#L173:

# dont ship the same exception instance twice
if exc_info[1] in self._exc_queue:
    exc_info = None, None, None
self._exc_queue.put(exc_info[1])

But I can't see any tests around this to make sure. This is probably not trivial, but it'd be nice to see the case where this is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant