Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils_conv.get_toeplitz_channels_last() assume a squared kernel #116

Open
nhuet opened this issue Nov 6, 2023 · 0 comments
Open

utils_conv.get_toeplitz_channels_last() assume a squared kernel #116

nhuet opened this issue Nov 6, 2023 · 0 comments

Comments

@nhuet
Copy link
Contributor

nhuet commented Nov 6, 2023

When extracting image patches, a squared filter size based on conv_layer.kernel.shape[0] is used.
We could perhaps use the actual kernel size, potentially rectangular: conv_layer.kernel_size (which is a 2-length tuple after Conv2D initialization).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant