Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inject_into paths instead of strings when injecting into JSON body #48493

Open
erohmensing opened this issue Nov 14, 2024 · 0 comments

Comments

@erohmensing
Copy link
Contributor

Problem

For certain use cases like GraphQL's variables, we want to inject a value (such as a pagination value or a cursor value for incremental) into not a top-level key, but a nested value (e.g. `{"variables": {"after": ""}}. Currently you can hack this a little bit for some values, like pagination cursor values, by providing an object as the cursor value:

Image

However, for other fields you cannot, since you don't have control over the formatting of the value itself (e.g. as in incremental sync where you can only give the path to the value and the date formatter, but not the format of the object itself).

In any case, once you want to inject multiple keys into the top-level key, you then run into errors in the CDK about duplicate keys - so they don't merge.

Solution

We want to be able to inject into a key path on a Body JSON Payload instead of a key. The suggestion of the UX would be that if you have selected to inject into a Body JSON Payload, the following UI that you currently get:

Image

would have Key Path instead of Key Value, and would give you the path input field

Image.

Note that for injecting into Query Parameter, Header, Path, or Body data (urlencoded form) the input fields should stay as they are.

@erohmensing erohmensing added area/connectors Connector related issues needs-triage type/bug Something isn't working team/marketplace area/connector-builder and removed needs-triage type/bug Something isn't working area/connectors Connector related issues labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant